Messages in this thread | | | From | Dexuan Cui <> | Subject | RE: [PATCH net] skbuff.h: Improve the checksum related comments | Date | Mon, 6 Apr 2020 01:25:29 +0000 |
| |
> From: Randy Dunlap <rdunlap@infradead.org> > Sent: Sunday, April 5, 2020 9:41 AM > To: Dexuan Cui <decui@microsoft.com>; Matthew Wilcox > >> Why the capitalisation of 'AND'? > > ... > > The comma after the "CHECKSUM_PARTIAL" seems suspicious to me. I feel > > we should add an "and" after the comma, or replace the comma with "and", > > but either way we'll have "... and csum_start and csum_offset...", which > > seems a little unnatural to me since we have 2 'and's here... So I tried to > > make it a little natural by replacing the first 'and' with 'AND', which > > obviously causes confusion to you. > > maybe "both csum_start and csum_offset are set to refer to". > ~Randy
Looks good. I'll post a v2 shortly. Thank you both!
Thanks, -- Dexuan
| |