Messages in this thread | | | From | "Manali Shukla (manashuk)" <> | Subject | Re: [ PATCH stable v4.19] EDAC: Drop per-memory controller buses | Date | Sun, 5 Apr 2020 19:26:01 +0000 |
| |
> On 05/04/20, 11:36 PM, "Borislav Petkov" <bp@suse.de> wrote:
> On Sun, Apr 05, 2020 at 06:01:21PM +0000, Manali Shukla (manashuk) wrote: >> With this patch , we are removing per-MC bus, this removes dependency on value of max number of controllers (EDAC_MAX_MCS) which is hardcoded to 2 * MAX_NUMNODES in all stable versions of kernel. >> On two nodes system MAX_NUMNODES value is ‘1’ , so value of max number of memory controller becomes ‘2’, this patch fixes this issue when there are only 2 nodes on the system and number of memory controllers are more than ‘2'
> You basically repeated what you had written already.
> But what is this fixing? Some platform of yours or what? Why does it > need to go to stable?
Certain MIPS platform can have 2 nodes and number of memory controllers can be more than '2' .
for above condition, if #define EDAC_MAX_MCS 2 * MAX_NUMNODES, it fails in this function edac_mc_add_mc_with_groups in below condition if (mci->mc_idx >= EDAC_MAX_MCS) { pr_warn_once("Too many memory controllers: %d\n", mci->mc_idx); return -ENODEV; } That is why this fix is needed.
> Btw, please do not top-post and reply under the quoted text like all of > us do. > Thx. -- > Regards/Gruss, > Boris. > SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
Thanks Manali
| |