Messages in this thread | | | Subject | Re: [GIT PULL] Please pull proc and exec work for 5.7-rc1 | From | Bernd Edlinger <> | Date | Thu, 30 Apr 2020 16:29:47 +0200 |
| |
Hi Linus,
On 4/30/20 3:47 PM, Linus Torvalds wrote: > On Thu, Apr 30, 2020 at 6:39 AM Bernd Edlinger > <bernd.edlinger@hotmail.de> wrote: >> >> Excuse me, but what in my /proc folder there is no attr/something >> is there a procfs equivalent of pthread_attach ? >> >> What exactly is "attr/something" ? > > Anything that uses that proc_pid_attr_write(). > > Which you should have realized, since you wrote the patch that changed > that function to return -EAGAIN. >
Ah, now I see, that was of course not the intended effect, but that is not where the pseudo-deadlock happens at all, would returning -RESTARTNOINTR in this function make this patch acceptable, it will not have an effect on the test case?
Bernd.
> That's > > /proc/<pid>/attr/{current,exec,fscreate,keycreate,prev,sockcreate} > > and some smack files. > > Your patch definitely made them return -EINVAL if they happen in that > execve() black hole, instead of waiting for the execve() to just > complete and then just work. > > Dropping a lock really is broken. It';s broken even if you then set a > flag saying "I dropped the lock, now you can't use it". > > Linus >
| |