| Subject | Re: [RFC PATCH v11 6/9] media: tegra: Add Tegra210 Video input driver | From | Dmitry Osipenko <> | Date | Thu, 30 Apr 2020 16:43:10 +0300 |
| |
30.04.2020 01:00, Sowjanya Komatineni пишет: > +void tegra_channel_release_buffers(struct tegra_vi_channel *chan, > + enum vb2_buffer_state state) > +{ > + struct tegra_channel_buffer *buf, *nbuf; > + > + spin_lock(&chan->start_lock); > + list_for_each_entry_safe(buf, nbuf, &chan->capture, queue) { > + vb2_buffer_done(&buf->buf.vb2_buf, state); > + list_del(&buf->queue); > + } > +
I'd remove this blank line to make lock/unlock block more human-readable.
> + spin_unlock(&chan->start_lock); > + > + spin_lock(&chan->done_lock); > + list_for_each_entry_safe(buf, nbuf, &chan->done, queue) { > + vb2_buffer_done(&buf->buf.vb2_buf, state); > + list_del(&buf->queue); > + } > +
And thins line too.
> + spin_unlock(&chan->done_lock); > +}
|