lkml.org 
[lkml]   [2020]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ZYNQ: platsmp: Return -ENOMEM after a failed ioremap() call in zynq_cpun_start()
From
Date
On 30. 04. 20 11:00, Markus Elfring wrote:
>> In ioremap we should return -ENOMEM when it reports an
>> memory allocation failure.
>
> I suggest to improve this change description.
>
> Will the tag “Fixes” be relevant because of the adjusted error code?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=1d2cc5ac6f6668cc15216d51051103c61467d7e8#n183

I don't think this was found by bisection because arm smp code cares
only about 0 - success and !0. I would expect any static program
analysis tool like coccinelle.

Would be good to rewrite that commit message and simply say that
failures from ioremaps returns -ENOMEM.

Thanks,
Michal

\
 
 \ /
  Last update: 2020-04-30 11:21    [W:0.039 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site