Messages in this thread | | | Date | Thu, 30 Apr 2020 17:49:19 -0700 (PDT) | Subject | Re: [PATCH] dp83640: reverse arguments to list_add_tail | From | David Miller <> |
| |
From: Julia Lawall <Julia.Lawall@inria.fr> Date: Thu, 30 Apr 2020 21:51:32 +0200
> In this code, it appears that phyter_clocks is a list head, based on > the previous list_for_each, and that clock->list is intended to be a > list element, given that it has just been initialized in > dp83640_clock_init. Accordingly, switch the arguments to > list_add_tail, which takes the list head as the second argument. > > Fixes: cb646e2b02b27 ("ptp: Added a clock driver for the National Semiconductor PHYTER.") > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
This looks correct to me too.
Applied and queued up for -stable, thanks.
| |