Messages in this thread | | | Date | Thu, 30 Apr 2020 14:32:15 -0700 | From | Jerry Snitselaar <> | Subject | Re: [PATCH] efi/tpm: fix section mismatch warning |
| |
On Thu Apr 30 20, Ard Biesheuvel wrote: >On Thu, 30 Apr 2020 at 23:21, Arnd Bergmann <arnd@arndb.de> wrote: >> >> On Thu, Apr 30, 2020 at 11:15 PM Jerry Snitselaar <jsnitsel@redhat.com> wrote: >> > >> > On Wed Apr 29 20, Arnd Bergmann wrote: >> > >Building with gcc-10 causes a harmless warning about a section mismatch: >> > > >> > >WARNING: modpost: vmlinux.o(.text.unlikely+0x5e191): Section mismatch in reference from the function tpm2_calc_event_log_size() to the function .init.text:early_memunmap() >> > >The function tpm2_calc_event_log_size() references >> > >the function __init early_memunmap(). >> > >This is often because tpm2_calc_event_log_size lacks a __init >> > >annotation or the annotation of early_memunmap is wrong. >> > > >> > >Add the missing annotation. >> > > >> > >Fixes: e658c82be556 ("efi/tpm: Only set 'efi_tpm_final_log_size' after successful event log parsing") >> > >Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> > >> > Minor thing, but should the Fixes be c46f3405692d ("tpm: Reserve the TPM final events table")? Or what am I missing >> > about e658c82be556 that causes this? Just trying to understand what I did. :) >> >> You are right, I misread the git history. Can you fix it up when applying the >> patch, or should I resend it? >> > >I can fix it up, no worries. >
With the fix applied:
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
| |