lkml.org 
[lkml]   [2020]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] efi/tpm: fix section mismatch warning
    On Wed Apr 29 20, Arnd Bergmann wrote:
    >Building with gcc-10 causes a harmless warning about a section mismatch:
    >
    >WARNING: modpost: vmlinux.o(.text.unlikely+0x5e191): Section mismatch in reference from the function tpm2_calc_event_log_size() to the function .init.text:early_memunmap()
    >The function tpm2_calc_event_log_size() references
    >the function __init early_memunmap().
    >This is often because tpm2_calc_event_log_size lacks a __init
    >annotation or the annotation of early_memunmap is wrong.
    >
    >Add the missing annotation.
    >
    >Fixes: e658c82be556 ("efi/tpm: Only set 'efi_tpm_final_log_size' after successful event log parsing")
    >Signed-off-by: Arnd Bergmann <arnd@arndb.de>

    Minor thing, but should the Fixes be c46f3405692d ("tpm: Reserve the TPM final events table")? Or what am I missing
    about e658c82be556 that causes this? Just trying to understand what I did. :)

    Regards,
    Jerry

    >---
    > drivers/firmware/efi/tpm.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    >diff --git a/drivers/firmware/efi/tpm.c b/drivers/firmware/efi/tpm.c
    >index 31f9f0e369b9..55b031d2c989 100644
    >--- a/drivers/firmware/efi/tpm.c
    >+++ b/drivers/firmware/efi/tpm.c
    >@@ -16,7 +16,7 @@
    > int efi_tpm_final_log_size;
    > EXPORT_SYMBOL(efi_tpm_final_log_size);
    >
    >-static int tpm2_calc_event_log_size(void *data, int count, void *size_info)
    >+static int __init tpm2_calc_event_log_size(void *data, int count, void *size_info)
    > {
    > struct tcg_pcr_event2_head *header;
    > int event_size, size = 0;
    >--
    >2.26.0
    >

    \
     
     \ /
      Last update: 2020-04-30 23:15    [W:6.558 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site