lkml.org 
[lkml]   [2020]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH v3 3/7] n_tty: Send SIGINFO to fg pgrp on status request character
    No kerninfo line is printed yet.

    No existing implementation of this on any Unix-like system echoes
    the status character; no existing implementation discards or flushes
    pending input on VSTATUS receipt. Thus we do neither.

    There are existing popular TUI applications (e. g. mutt) that only
    turn off icanon and not iexten, but still do not expect any special
    treatment of the status request character — so we require all three:
    isig, icanon and iexten to trigger this.

    Signed-off-by: Arseny Maslennikov <ar@cs.msu.ru>
    ---
    drivers/tty/n_tty.c | 15 +++++++++++++--
    include/linux/tty.h | 1 +
    2 files changed, 14 insertions(+), 2 deletions(-)

    diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
    index 1794d84e7..10d6b60a5 100644
    --- a/drivers/tty/n_tty.c
    +++ b/drivers/tty/n_tty.c
    @@ -79,6 +79,10 @@
    #define ECHO_BLOCK 256
    #define ECHO_DISCARD_WATERMARK N_TTY_BUF_SIZE - (ECHO_BLOCK + 32)

    +#define SIG_FLUSHING_MASK ( \
    + rt_sigmask(SIGINT) | rt_sigmask(SIGQUIT) | \
    + rt_sigmask(SIGTSTP) )
    +#define SIG_FLUSHING(sig) ((1 << sig) & SIG_FLUSHING_MASK)

    #undef N_TTY_TRACE
    #ifdef N_TTY_TRACE
    @@ -1122,7 +1126,7 @@ static void isig(int sig, struct tty_struct *tty)
    {
    struct n_tty_data *ldata = tty->disc_data;

    - if (L_NOFLSH(tty)) {
    + if (L_NOFLSH(tty) || (!SIG_FLUSHING(sig))) {
    /* signal only */
    __isig(sig, tty);

    @@ -1244,7 +1248,8 @@ n_tty_receive_signal_char(struct tty_struct *tty, int signal, unsigned char c)
    if (I_IXON(tty))
    start_tty(tty);
    if (L_ECHO(tty)) {
    - echo_char(c, tty);
    + if (c != STATUS_CHAR(tty))
    + echo_char(c, tty);
    commit_echoes(tty);
    } else
    process_echoes(tty);
    @@ -1294,6 +1299,9 @@ n_tty_receive_char_special(struct tty_struct *tty, unsigned char c)
    } else if (c == SUSP_CHAR(tty)) {
    n_tty_receive_signal_char(tty, SIGTSTP, c);
    return 0;
    + } else if (c == STATUS_CHAR(tty)) {
    + n_tty_receive_signal_char(tty, SIGINFO, c);
    + return 0;
    }
    }

    @@ -1848,6 +1856,9 @@ static void n_tty_set_termios(struct tty_struct *tty, struct ktermios *old)
    set_bit(INTR_CHAR(tty), ldata->char_map);
    set_bit(QUIT_CHAR(tty), ldata->char_map);
    set_bit(SUSP_CHAR(tty), ldata->char_map);
    + if (L_ICANON(tty) && L_IEXTEN(tty)) {
    + set_bit(STATUS_CHAR(tty), ldata->char_map);
    + }
    }
    clear_bit(__DISABLED_CHAR, ldata->char_map);
    ldata->raw = 0;
    diff --git a/include/linux/tty.h b/include/linux/tty.h
    index bd5fe0e90..8411fd18d 100644
    --- a/include/linux/tty.h
    +++ b/include/linux/tty.h
    @@ -120,6 +120,7 @@ struct tty_bufhead {
    #define WERASE_CHAR(tty) ((tty)->termios.c_cc[VWERASE])
    #define LNEXT_CHAR(tty) ((tty)->termios.c_cc[VLNEXT])
    #define EOL2_CHAR(tty) ((tty)->termios.c_cc[VEOL2])
    +#define STATUS_CHAR(tty) ((tty)->termios.c_cc[VSTATUS])

    #define _I_FLAG(tty, f) ((tty)->termios.c_iflag & (f))
    #define _O_FLAG(tty, f) ((tty)->termios.c_oflag & (f))
    --
    2.26.2
    \
     
     \ /
      Last update: 2020-04-30 09:18    [W:4.585 / U:1.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site