Messages in this thread | | | Subject | Re: [PATCH] pipe: read/write_iter() handler should check for IOCB_NOWAIT | From | Jens Axboe <> | Date | Thu, 30 Apr 2020 12:47:03 -0600 |
| |
On 4/30/20 11:58 AM, Matthew Wilcox wrote: > On Thu, Apr 30, 2020 at 10:24:46AM -0600, Jens Axboe wrote: >> Pipe read/write only checks for the file O_NONBLOCK flag, but we should >> also check for IOCB_NOWAIT for whether or not we should handle this read >> or write in a non-blocking fashion. If we don't, then we will block on >> data or space for iocbs that explicitly asked for non-blocking >> operation. This messes up callers that explicitly ask for non-blocking >> operations. >> >> Signed-off-by: Jens Axboe <axboe@kernel.dk> > > Wouldn't this be better?
Yeah, that's probably a better idea. Care to send a "proper" patch?
-- Jens Axboe
| |