Messages in this thread | | | Date | Thu, 30 Apr 2020 21:52:46 +0530 | From | Syed Nayyar Waris <> | Subject | Re: [PATCH v3 3/4] gpio: thunderx: Utilize for_each_set_clump macro |
| |
On Wed, Apr 29, 2020 at 01:17:42PM +0300, Andy Shevchenko wrote: > On Wed, Apr 29, 2020 at 04:37:41AM +0530, Syed Nayyar Waris wrote: > > This patch reimplements the thunderx_gpio_set_multiple function in > > drivers/gpio/gpio-thunderx.c to use the new for_each_set_clump macro. > > Instead of looping for each bank in thunderx_gpio_set_multiple > > function, now we can skip bank which is not set and save cycles. > > > + const unsigned long bank_size = 64; > > Shouldn't be rather definition?
Thanks. I think you mean macro definition. I will incorporate this in my next version.
> > -- > With Best Regards, > Andy Shevchenko > >
| |