lkml.org 
[lkml]   [2020]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH RFC 4/6] KVM: x86: acknowledgment mechanism for async pf page ready notifications
    From
    Date
    On 29/04/20 11:36, Vitaly Kuznetsov wrote:
    > + case MSR_KVM_ASYNC_PF_ACK:
    > + if (data & 0x1)
    > + kvm_check_async_pf_completion(vcpu);
    > + break;

    Does this work if interrupts are turned off? I think in that case
    kvm_check_async_pf_completion will refuse to make progress. You need to
    make this bit stateful (e.g. 1 = async PF in progress, 0 = not in
    progress), and check that for page ready notifications instead of
    EFLAGS.IF. This probably means that;

    - it might be simpler to move it to the vector MSR

    - it's definitely much simpler to remove the #PF-based mechanism for
    injecting page ready notifications.

    Thanks,

    Paolo

    \
     
     \ /
      Last update: 2020-04-30 08:50    [W:4.027 / U:0.832 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site