Messages in this thread | | | From | Chaitanya Kulkarni <> | Subject | Re: [PATCH] nvmet: add revalidation support to bdev and file backed namespaces | Date | Fri, 3 Apr 2020 20:29:56 +0000 |
| |
On 04/02/2020 12:31 PM, Anthony Iliopoulos wrote: > +void nvmet_file_ns_revalidate(struct nvmet_ns *ns) > +{ > + struct kstat stat; > + > + if (!ns->file) > + return; No need for the above check. > + > + if (vfs_getattr(&ns->file->f_path, > + &stat, STATX_SIZE, AT_STATX_FORCE_SYNC)) > + return;
Error handling needed ? What should we set ns->size if vfs_getattr fails ? in case of error what nvmet_identify_ns() report success or a failure ? > + > + ns->size = stat.size; bdev checks the ns->size != size, why the same check is not here ?
Just remove the check from bdev and see my comment there. > +}
| |