Messages in this thread | | | Date | Fri, 3 Apr 2020 20:20:05 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 5/7] x86/speculation: Annotate intra-function calls |
| |
On Fri, Apr 03, 2020 at 12:24:08PM -0500, Josh Poimboeuf wrote: > On Fri, Apr 03, 2020 at 07:18:36PM +0200, Peter Zijlstra wrote: > > What we need in this case though is only a different stack layout inside > > the alternative, and that is doable. > > I'm not sure what you mean... any stack changes within the alternative > have to match exactly the stack changes at the same offsets of the > original code because ORC doesn't know the difference between the two.
I mean that the ORC entries on either side of the alternative have to be invariant wrt the specific alternative chosen, but that -- provded you whip up that ORC alternative stuff -- stack layout inside of an alternative could possibly be different.
| |