Messages in this thread | | | Date | Fri, 3 Apr 2020 11:20:39 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH v2] objtool: Documentation: document UACCESS warnings |
| |
On Thu, Mar 26, 2020 at 11:37:06AM -0700, Nick Desaulniers wrote: > Compiling with Clang and CONFIG_KASAN=y was exposing a few warnings: > call to memset() with UACCESS enabled > > Document how to fix these for future travelers. > > Link: https://github.com/ClangBuiltLinux/linux/issues/876 > Suggested-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> > Suggested-by: Matt Helsley <mhelsley@vmware.com> > Suggested-by: Peter Zijlstra <peterz@infradead.org> > Suggested-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > --- > Changes V1 -> V2: > * fix typo of listing uaccess_enable() twice rather than > uaccess_disable() as per Matt and Kamalesh. > * fix type of "should called" to "should be called" as per Randy. > * Mention non-obvious compiler instrumentation ie. -pg/mcount > -mfentry/fentry via tracing as per Peter. > * Add sentence "It also helps verify..." > * Add potential fix "1) remove explicit..."
Thanks, adding this one to the queue for tip.
-- Josh
| |