lkml.org 
[lkml]   [2020]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/5] ipc/msg: Add missing annotation for freeque()
    Date
    Sparse reports a warning at freeque()

    warning: context imbalance in freeque() - unexpected unlock

    The root cause is the missing annotation at freeque()

    Add the missing __releases(RCU) annotation
    Add the missing __releases(&msq->q_perm) annotation

    Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
    ---
    ipc/msg.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/ipc/msg.c b/ipc/msg.c
    index caca67368cb5..acd1bc7af55a 100644
    --- a/ipc/msg.c
    +++ b/ipc/msg.c
    @@ -268,6 +268,8 @@ static void expunge_all(struct msg_queue *msq, int res,
    * before freeque() is called. msg_ids.rwsem remains locked on exit.
    */
    static void freeque(struct ipc_namespace *ns, struct kern_ipc_perm *ipcp)
    + __releases(RCU)
    + __releases(&msq->q_perm)
    {
    struct msg_msg *msg, *t;
    struct msg_queue *msq = container_of(ipcp, struct msg_queue, q_perm);
    --
    2.24.1
    \
     
     \ /
      Last update: 2020-04-03 18:06    [W:4.402 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site