Messages in this thread Patch in this message | | | Date | Fri, 3 Apr 2020 15:48:57 +0100 | From | Luis Henriques <> | Subject | Re: [PATCH] fscache: drop fscache_cookie_put on duplicated cookies in the hash |
| |
Ping?
Cheers, -- Luis
On Mon, Mar 09, 2020 at 04:16:43PM +0000, Luis Henriques wrote: > When there's a collision due to a duplicate cookie, __fscache_register_netfs > will do an fscache_cookie_put. This, however, isn't required as > fscache_cookie_get hasn't been executed, and will lead to a NULL pointer as > fscache_unhash_cookie will be called. > > Signed-off-by: Luis Henriques <lhenriques@suse.com> > --- > fs/fscache/netfs.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/fscache/netfs.c b/fs/fscache/netfs.c > index cce92216fa28..07a55371f0a4 100644 > --- a/fs/fscache/netfs.c > +++ b/fs/fscache/netfs.c > @@ -52,7 +52,6 @@ int __fscache_register_netfs(struct fscache_netfs *netfs) > return 0; > > already_registered: > - fscache_cookie_put(candidate, fscache_cookie_put_dup_netfs); > _leave(" = -EEXIST"); > return -EEXIST; > }
| |