Messages in this thread | | | Date | Fri, 3 Apr 2020 17:35:59 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH] mm: thp: don't need drain lru cache when splitting and mlocking THP |
| |
On Sat, Mar 28, 2020 at 03:29:40AM +0800, Yang Shi wrote: > Since the commit 8f182270dfec ("mm/swap.c: flush lru pvecs on compound > page arrival") THP would not stay in pagevec anymore. So the > optimization made by commit d965432234db ("thp: increase > split_huge_page() success rate") doesn't make sense anymore, which tries > to unpin munlocked THPs from pagevec by draining pagevec. > > And draining lru cache before isolating THP in mlock path is unnecessary > either. > > Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Cc: Hugh Dickins <hughd@google.com> > Cc: Andrea Arcangeli <aarcange@redhat.com> > Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
-- Kirill A. Shutemov
| |