Messages in this thread | | | From | <> | Subject | [RFC PATCH 0/3] net: macb: Wake-on-Lan magic packet fixes | Date | Fri, 3 Apr 2020 15:14:41 +0200 |
| |
From: Nicolas Ferre <nicolas.ferre@microchip.com>
Hi, Here are some of my early patches in order to fix WoL magic-packet on the current macb driver. Addition of this feature to GEM types of IPs is yet to come. I would like to have your feedback on these little patches first so that I can continue investigating the addition of GEM WoL magic-packet.
Harini, I know that you have patches for GEM in order to integrate WoL ARP mode [1]. I'll try to integrate some of your work but would need that this feature is better integrated in current code. For instance, the choice of "magic packet" or "ARP" should be done by ethtool options and DT properties. For matching with mainline users, MACB and GEM code must co-exist. The use of dumb buffers for RX seems also fairly platform specific and we would need to think more about it.
[1]: https://github.com/Xilinx/linux-xlnx/commit/e9648006e8d9132db2594e50e700af362b3c9226#diff-41909d180431659ccc1229aa30fd4e5a https://github.com/Xilinx/linux-xlnx/commit/60a21c686f7e4e50489ae04b9bb1980b145e52ef
Nicolas Ferre (3): net: macb: fix wakeup test in runtime suspend/resume routines net: macb: mark device wake capable when "magic-packet" property present net: macb: fix macb_get/set_wol() when moving to phylink
drivers/net/ethernet/cadence/macb_main.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-)
-- 2.20.1
| |