Messages in this thread | | | Date | Fri, 3 Apr 2020 13:01:13 +0200 | From | Alex Riesen <> | Subject | Re: [PATCH v5 1/9] media: adv748x: fix end-of-line terminators in diagnostic statements |
| |
Kieran Bingham, Fri, Apr 03, 2020 12:43:38 +0200: > Hi Alex, > > On 02/04/2020 19:34, Alex Riesen wrote: > > Signed-off-by: Alexander Riesen <alexander.riesen@cetitec.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > I guess we could have also added this directly to the helper macros, but > there is indeed already a mixed usage so either way would require fixups > to be consistent. > > So this is a good option ;-)
Not in this particular driver (unless I missed it), but yes, this was my main motivation. Also size of unrelated changes in the patch series and I prefer to have the ability to format diagnostics sequentially (also used it this time, only removed the debugging traces later).
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Thanks!
| |