Messages in this thread | | | Subject | Re: [PATCH] mfd: asic3: Delete redundant variable definition | From | Markus Elfring <> | Date | Fri, 3 Apr 2020 10:11:04 +0200 |
| |
> In this function, 'ret' is always assigned, even if 'pdata->leds' > don't carry out,
I notice possibilities again to improve such a commit message.
> it has already been assigned a value in the above code, including '0',
The variable assignment will eventually be performed only in if branches.
> so it's redundant.
I suggest to reconsider this interpretation of the source code here. Would you like to move the mentioned statement into an else branch at the end?
Regards, Markus
| |