Messages in this thread | | | Subject | Re: [PATCH v3 2/7] clocksource: Add Tegra186 timers support | From | Dmitry Osipenko <> | Date | Fri, 3 Apr 2020 23:45:04 +0300 |
| |
03.04.2020 23:22, Thierry Reding пишет: ... > +config TEGRA186_TIMER > + tristate "NVIDIA Tegra186 timer driver" > + depends on ARCH_TEGRA || COMPILE_TEST > + depends on WATCHDOG && WATCHDOG_CORE > + help > + Enables support for the timers and watchdogs found on NVIDIA > + Tegra186 and later SoCs.
Personally, I'd like to see this in drivers/watchdog/ because I've seen cases where subsys maintainers are doing bulk-changes to drivers and missing those that reside outside of the subsys directory.
But, that's not to me to decide, so I don't really mind.
... > +static void tegra186_wdt_enable(struct tegra186_wdt *wdt) > +{ > + struct tegra186_timer *tegra = wdt->tmr->parent; > + u32 value; > + > + /* unmask hardware IRQ, this may have been lost across powergate */ > + value = TKEIE_WDT_MASK(wdt->index, 1); > + writel(value, tegra->regs + TKEIE(wdt->tmr->hwirq));
Perhaps this one also could be relaxed, for consistency. Sorry for missing it in v2 :)
| |