lkml.org 
[lkml]   [2020]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/5] ext4: unsigned int compared against zero
    Date
    From: Colin Ian King <colin.king@canonical.com>

    commit fbbbbd2f28aec991f3fbc248df211550fbdfd58c upstream.

    There are two cases where u32 variables n and err are being checked
    for less than zero error values, the checks is always false because
    the variables are not signed. Fix this by making the variables ints.

    Addresses-Coverity: ("Unsigned compared against 0")
    Fixes: 345c0dbf3a30 ("ext4: protect journal inode's blocks using block_validity")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Ashwin H <ashwinh@vmware.com>
    ---
    fs/ext4/block_validity.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c
    index 9c9c639..d31d93e 100644
    --- a/fs/ext4/block_validity.c
    +++ b/fs/ext4/block_validity.c
    @@ -141,7 +141,8 @@ static int ext4_protect_reserved_inode(struct super_block *sb, u32 ino)
    struct inode *inode;
    struct ext4_sb_info *sbi = EXT4_SB(sb);
    struct ext4_map_blocks map;
    - u32 i = 0, err = 0, num, n;
    + u32 i = 0, num;
    + int err = 0, n;

    if ((ino < EXT4_ROOT_INO) ||
    (ino > le32_to_cpu(sbi->s_es->s_inodes_count)))
    --
    2.7.4
    \
     
     \ /
      Last update: 2020-04-29 13:48    [W:2.345 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site