lkml.org 
[lkml]   [2020]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v7 3/5] powerpc/hv-24x7: Add sysfs files inside hv-24x7 device to show processor details
    From
    Date


    On 3/27/20 12:06 PM, Kajol Jain wrote:
    > To expose the system dependent parameter like total number of
    > sockets and numbers of chips per socket, patch adds two sysfs files.
    > "sockets" and "chips" are added to /sys/devices/hv_24x7/interface/
    > of the "hv_24x7" pmu.
    >
    > Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
    > ---
    > arch/powerpc/perf/hv-24x7.c | 22 ++++++++++++++++++++++
    > 1 file changed, 22 insertions(+)
    >
    > diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c
    > index 9ae00f29bd21..a31bd5b88f7a 100644
    > --- a/arch/powerpc/perf/hv-24x7.c
    > +++ b/arch/powerpc/perf/hv-24x7.c
    > @@ -454,6 +454,20 @@ static ssize_t device_show_string(struct device *dev,
    > return sprintf(buf, "%s\n", (char *)d->var);
    > }
    >
    > +#ifdef CONFIG_PPC_RTAS
    > +static ssize_t sockets_show(struct device *dev,
    > + struct device_attribute *attr, char *buf)
    > +{
    > + return sprintf(buf, "%d\n", physsockets);
    > +}
    > +
    > +static ssize_t chips_show(struct device *dev, struct device_attribute *attr,
    > + char *buf)
    > +{
    > + return sprintf(buf, "%d\n", physchips);
    > +}
    > +#endif
    > +

    rtas call gives you the cores per chip too. We can expose that
    also with this patch?  I understand tool side patchset is using
    only metrics added to socket/chip information, its better to
    include that cores also here..

    > static struct attribute *device_str_attr_create_(char *name, char *str)
    > {
    > struct dev_ext_attribute *attr = kzalloc(sizeof(*attr), GFP_KERNEL);
    > @@ -1100,6 +1114,10 @@ PAGE_0_ATTR(catalog_len, "%lld\n",
    > (unsigned long long)be32_to_cpu(page_0->length) * 4096);
    > static BIN_ATTR_RO(catalog, 0/* real length varies */);
    > static DEVICE_ATTR_RO(domains);
    > +#ifdef CONFIG_PPC_RTAS
    > +static DEVICE_ATTR_RO(sockets);
    > +static DEVICE_ATTR_RO(chips);
    > +#endif
    >
    > static struct bin_attribute *if_bin_attrs[] = {
    > &bin_attr_catalog,
    > @@ -1110,6 +1128,10 @@ static struct attribute *if_attrs[] = {
    > &dev_attr_catalog_len.attr,
    > &dev_attr_catalog_version.attr,
    > &dev_attr_domains.attr,
    > +#ifdef CONFIG_PPC_RTAS
    > + &dev_attr_sockets.attr,
    > + &dev_attr_chips.attr,
    > +#endif
    > NULL,
    > };
    >

    \
     
     \ /
      Last update: 2020-04-29 11:10    [W:2.654 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site