Messages in this thread | | | Subject | Re: [RFC PATCH 1/3] sched/fair: Call newidle_balance() from finish_task_switch() | From | Scott Wood <> | Date | Wed, 29 Apr 2020 20:36:38 -0500 |
| |
On Wed, 2020-04-29 at 10:27 +0200, Vincent Guittot wrote: > On Tue, 28 Apr 2020 at 07:02, Scott Wood <swood@redhat.com> wrote: > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index 02f323b85b6d..74c3c5280d6b 100644 > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c > > @@ -6758,8 +6758,6 @@ balance_fair(struct rq *rq, struct task_struct > > *prev, struct rq_flags *rf) > > { > > if (rq->nr_running) > > return 1; > > - > > - return newidle_balance(rq, rf) != 0; > > Missing return ?
Yes, editing error during last minute cleanup. :-P
-Scott
| |