lkml.org 
[lkml]   [2020]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 03/10] efi/x86: Use pr_efi_err for error messages
On Wed, 29 Apr 2020 at 23:53, Joe Perches <joe@perches.com> wrote:
>
> On Wed, 2020-04-29 at 17:43 -0400, Arvind Sankar wrote:
> > On Wed, Apr 29, 2020 at 08:49:21PM +0200, Ard Biesheuvel wrote:
> > > On Wed, 29 Apr 2020 at 20:47, Joe Perches <joe@perches.com> wrote:
> > > > On Wed, 2020-04-29 at 13:41 -0400, Arvind Sankar wrote:
> > > > > Use pr_efi_err instead of bare efi_printk for error messages.
> > > >
> > > > Perhaps it'd be better to rename pr_efi_err to eri_err
> > > > so it's clearer it's a typical efi_ logging function.
> > > >
> > > > $ git grep -w --name-only pr_efi_err | \
> > > > xargs sed -i 's/\bpr_efi_err\b/efi_err/g'
> > > >
> > >
> > > Yeah, pr_efi_err() is probably not the best name
> >
> > Should I rename pr_efi/pr_efi_err to, say, efi_pr_info/efi_pr_error?
>
> Perhaps not use pr_ in the name at all.
>
> I suggest:
>
> pr_efi -> efi_info (or efi_debug or efi_dbg)
> (it is guarded by an efi_quiet flag, default: on)
> pr_efi_err -> efi_err
>

Agreed. Shorter is better if there is no risk of confusion..

\
 
 \ /
  Last update: 2020-04-29 23:55    [W:0.112 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site