Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 28 Apr 2020 16:00:36 +0200 | Subject | Re: [PATCH] gpio: of: Build fails if CONFIG_OF_DYNAMIC enabled without CONFIG_OF_GPIO |
| |
On Sat, Apr 25, 2020 at 6:46 AM David Gow <davidgow@google.com> wrote:
> The symbol 'gpio_of_notifier' doesn't exist without both CONFIG_OF_GPIO > and CONFIG_OF_DYNAMIC enabled, but is referenced when only > CONFIG_OF_DYNAMIC is enabled. > > This broke building with 'make ARCH=um allyesconfig': > --------------- > /usr/bin/ld: drivers/gpio/gpiolib.o: in function `gpiolib_dev_init': > ./drivers/gpio/gpiolib.c:5293: undefined reference to `gpio_of_notifier' > collect2: error: ld returned 1 exit status > --------------- > > Fixes: 63636d956c45 ("gpio: of: Add DT overlay support for GPIO hogs") > Signed-off-by: David Gow <davidgow@google.com>
Patch applied for fixes since it fixes a regression, I recommend looking a bit down the dependency chain as indicated by Geert if you have time!
Yours, Linus Walleij
| |