Messages in this thread | | | From | Clément Péron <> | Date | Tue, 28 Apr 2020 10:54:00 +0200 | Subject | Re: [PATCH 4/7] arm64: dts: allwinner: a64: Add HDMI audio |
| |
Hi Maxime,
On Tue, 28 Apr 2020 at 10:00, Maxime Ripard <maxime@cerno.tech> wrote: > > On Sun, Apr 26, 2020 at 02:04:39PM +0200, Clément Péron wrote: > > From: Marcus Cooper <codekipper@gmail.com> > > > > Add a simple-soundcard to link audio between HDMI and I2S. > > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> > > Signed-off-by: Marcus Cooper <codekipper@gmail.com> > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > --- > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 21 +++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > index e56e1e3d4b73..08ab6b5e72a5 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > @@ -102,6 +102,25 @@ > > status = "disabled"; > > }; > > > > + hdmi_sound: hdmi-sound { > > + compatible = "simple-audio-card"; > > + simple-audio-card,format = "i2s"; > > + simple-audio-card,name = "allwinner,hdmi"; > > I'm not sure what the usual card name should be like though. I would assume that > this should be something specific enough so that you're able to differentiate > between boards / SoC so that the userspace can choose a different configuration > based on it?
I really don't know what we should use here, I just have a look at other SoC: rk3328: "HDMI" rk3399: "hdmi-sound" r8a774c0-cat874: "CAT874 HDMI sound"
But maybe it's time to introduce proper name: What about : sun50i-a64-hdmi sun50i-h6-hdmi How should we handle this with h3 / h5 ? settings the simple-audio-card,name in each SoC dts? Or using sun50i-h3-hdmi as they are both identical?
Regards, Clement
> > If so, it's really too generic. > > Maxime
| |