lkml.org 
[lkml]   [2020]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v2 04/14] objtool: is_fentry_call() crashes if call has no destination
    From: Alexandre Chartre <alexandre.chartre@oracle.com>

    Fix is_fentry_call() so that it works if a call has no destination
    set (call_dest). This needs to be done in order to support intra-
    function calls.

    Signed-off-by: Alexandre Chartre <alexandre.chartre@oracle.com>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Link: https://lkml.kernel.org/r/20200414103618.12657-2-alexandre.chartre@oracle.com
    ---
    tools/objtool/check.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/tools/objtool/check.c
    +++ b/tools/objtool/check.c
    @@ -1490,7 +1490,7 @@ static int decode_sections(struct objtoo

    static bool is_fentry_call(struct instruction *insn)
    {
    - if (insn->type == INSN_CALL &&
    + if (insn->type == INSN_CALL && insn->call_dest &&
    insn->call_dest->type == STT_NOTYPE &&
    !strcmp(insn->call_dest->name, "__fentry__"))
    return true;

    \
     
     \ /
      Last update: 2020-04-28 21:40    [W:3.066 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site