lkml.org 
[lkml]   [2020]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4] staging: wfx: cleanup long lines in data_tx.c
    On Mon, Apr 27, 2020 at 11:50:23AM +0000, Jerome Pouiller wrote:
    > On Saturday 25 April 2020 13:32:34 CEST Suraj Upadhyay wrote:
    > > Break lines with length over 80 characters to
    > > conform to the linux coding style and refactor
    > > wherever necessary.
    > >
    > > Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
    > > ---
    > >
    > > Changes in v4:
    > > - Added a space after declaration in wfx_get_hw_rate().
    > > - A checkpatch warning for this commit is retained at line 75,
    > > to maintain uniformity in function declarations. (Reviewer
    > > jerome suggested).
    > >
    > > Changes in v3:
    > > - Changed the temporary variable name for the memzcmp statement
    > > to is_used. (as suggested).
    > > - Added a temporary ieee80211_supported_band variable to address
    > > the problem in wfx_get_hw_rate() more efficiently. (not
    > > suggested, but still).
    > >
    > > Changes in v2:
    > > - Introduced a temporary variable for the memzcmp statement.
    > > - Addressed the checkpatch problem with wfx_get_hw_rate().
    > > - Restored the function definition of wfx_tx_get_tx_parms
    > > as suggested by the reviewer.
    > > - Added suggested changes for req->packet_id statement.
    > >
    > > drivers/staging/wfx/data_tx.c | 40 +++++++++++++++++++++++------------
    > > 1 file changed, 26 insertions(+), 14 deletions(-)
    >
    > This patch does not contain the suggestions from Dan. However, it is
    > sufficient from my personal point of view.

    Yeah. It's fine. It wasn't 100% cut and paste from my suggestions but
    it did address the stuff I cared about. Thanks!

    Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

    regards,
    dan carpenter

    \
     
     \ /
      Last update: 2020-04-28 21:06    [W:2.420 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site