Messages in this thread | | | Subject | Re: [PATCH RFT] i2c: brcmstb: properly check NACK condition | From | Florian Fainelli <> | Date | Mon, 27 Apr 2020 11:28:55 -0700 |
| |
On 4/26/2020 1:12 AM, Wolfram Sang wrote: > From: Wolfram Sang <wsa@the-dreams.de> > > cppcheck rightfully complains about: > > drivers/i2c/busses/i2c-brcmstb.c:319:7: warning: Condition 'CMD_RD' is always true [knownConditionTrueFalse] > drivers/i2c/busses/i2c-brcmstb.c:319:17: warning: Condition 'CMD_WR' is always false [knownConditionTrueFalse] > if ((CMD_RD || CMD_WR) && > > Compare the values to the 'cmd' variable. > > Fixes: dd1aa2524bc5 ("i2c: brcmstb: Add Broadcom settop SoC i2c controller driver") > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Acked-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |