Messages in this thread | | | Date | Mon, 27 Apr 2020 23:25:36 +0530 | From | Pratyush Yadav <> | Subject | Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode |
| |
On 21/04/20 09:23AM, Boris Brezillon wrote: > +Pratyush who's working on a similar patchet [1]. > > Hello Mason, > > On Tue, 21 Apr 2020 14:39:42 +0800 > Mason Yang <masonccyang@mxic.com.tw> wrote: > > > Hello, > > > > This is repost of patchset from Boris Brezillon's > > [RFC,00/18] mtd: spi-nor: Proposal for 8-8-8 mode support [1]. > > I only quickly went through the patches you sent and saying it's a > repost of the RFC is a bit of a lie. You completely ignored the state > tracking I was trying to do to avoid leaving the flash in 8D mode when > suspending/resetting the board, and I think that part is crucial. If I > remember correctly, we already had this discussion so I must say I'm a > bit disappointed. > > Can you sync with Pratyush? I think his series [1] is better in that it > tries to restore the flash in single-SPI mode before suspend (it's > missing the shutdown case, but that can be easily added I think). Of > course that'd be even better to have proper state tracking at the SPI > NOR level.
Hi Mason,
I posted a re-roll of my series here [0]. Could you please base your changes on top of it? Let me know if the series is missing something you need.
[0] https://lore.kernel.org/linux-mtd/20200424184410.8578-1-p.yadav@ti.com/
-- Regards, Pratyush Yadav
| |