Messages in this thread | | | Date | Mon, 27 Apr 2020 08:11:21 +0200 | From | Marco Felsch <> | Subject | Re: [PATCH V5 1/2] dt-bindings: firmware: imx: Move system control into dt-binding headfile |
| |
Hi Anson,
sorry for jumping in..
On 20-04-26 16:11, Anson Huang wrote: > From: Dong Aisheng <aisheng.dong@nxp.com> > > i.MX8 SoCs DTS file needs system control macro definitions, so move them > into dt-binding headfile, then include/linux/firmware/imx/types.h can be > removed and those drivers using it should be changed accordingly. > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > Signed-off-by: Jacky Bai <ping.bai@nxp.com> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > Changes since V4: > - Use another patch for new added system controls and PM clock types. > --- > drivers/firmware/imx/imx-scu.c | 1 - > drivers/thermal/imx_sc_thermal.c | 2 +- > include/dt-bindings/firmware/imx/rsrc.h | 51 ++++++++++++++++++++++++++ > include/linux/firmware/imx/sci.h | 1 - > include/linux/firmware/imx/types.h | 65 --------------------------------- > 5 files changed, 52 insertions(+), 68 deletions(-) > delete mode 100644 include/linux/firmware/imx/types.h > > diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c > index f71eaa5..f3340fa 100644 > --- a/drivers/firmware/imx/imx-scu.c > +++ b/drivers/firmware/imx/imx-scu.c > @@ -8,7 +8,6 @@ > */ > > #include <linux/err.h> > -#include <linux/firmware/imx/types.h> > #include <linux/firmware/imx/ipc.h> > #include <linux/firmware/imx/sci.h> > #include <linux/interrupt.h>
You don't need this anymore here or was it a needless include?
Regards, Marco
| |