Messages in this thread | | | Subject | Re: [PATCH] brcmfmac: remove comparison to bool in brcmf_fws_attach() | From | Chi-Hsien Lin <> | Date | Mon, 27 Apr 2020 15:47:50 +0800 |
| |
On 04/26/2020 5:40, Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:2359:6-40: > WARNING: Comparison to bool > > Signed-off-by: Jason Yan <yanaijie@huawei.com> Reviewed-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>
> --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c > index 8cc52935fd41..2b7837887c0b 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c > @@ -2356,7 +2356,7 @@ struct brcmf_fws_info *brcmf_fws_attach(struct brcmf_pub *drvr) > fws->drvr = drvr; > fws->fcmode = drvr->settings->fcmode; > > - if ((drvr->bus_if->always_use_fws_queue == false) && > + if (!drvr->bus_if->always_use_fws_queue && > (fws->fcmode == BRCMF_FWS_FCMODE_NONE)) { > fws->avoid_queueing = true; > brcmf_dbg(INFO, "FWS queueing will be avoided\n"); >
| |