Messages in this thread | | | From | Thomas Gleixner <> | Subject | RE: [PATCH 6/7] x86/traps: Fix up invalid PASID | Date | Tue, 28 Apr 2020 02:20:18 +0200 |
| |
"Luck, Tony" <tony.luck@intel.com> writes: >> Just for the record I also suggested to have a proper errorcode in the >> #GP for ENQCMD and I surely did not suggest to avoid decoding the user >> instructions. > > Is the heuristic to avoid decoding the user instructions OK (you are just pointing > out that you should not be given credit for this part of the idea)?
I surely suggested the approach, but at the same time I asked for the error code and did not say that instruction checking needs to be avoided.
This comment was just to make it clear that there were other options discussed. IOW, the changelog should have some explicit explanations why:
- the error code idea does not work (according to HW folks)
- the instruction decoding has no real benefit because $REASONS
Thanks,
tglx
| |