Messages in this thread | | | Subject | Re: [PATCH] xfs: Use the correct style for SPDX License Identifier | From | Joe Perches <> | Date | Mon, 27 Apr 2020 13:38:58 -0700 |
| |
On Mon, 2020-04-27 at 12:40 -0700, Linus Torvalds wrote: > On Mon, Apr 27, 2020 at 11:59 AM Joe Perches <joe@perches.com> wrote: > > There's no real reason not to prefer the latest versions > > over the deprecated ones. > > Joe, your pedantic approach is really hard to work with. Please work on it.
License text especially _should_ be pedantic and precise.
> The fact is, there *is * a reason to avoid the pedantic "change to new > version" - pointless churn.
Have you *looked* at this proposed change?
It just changes // SPDX comments to /* */ in .h files.
It's generically useless churn as using the // style in .h files was only for old and now unsupported compiler versions.
> We have a lot of the original style spdx markers, because those are > what we started with. And changing them is pointless.
You and I (and apparently the SPDX group too as they deprecated it) disagree a bit here.
> I know you love your scripts to change things around, but to everybody > else it tends to be just extra work and noise.
Piecemeal changes aren't great.
Scripted changes can be very useful and I believe they are significantly underutilized in this source tree.
cheers, Joe
| |