Messages in this thread | | | Subject | Re: [PATCH -next] perf script: remove unneeded conversion to bool | From | Joe Perches <> | Date | Sun, 26 Apr 2020 13:59:36 -0700 |
| |
On Sun, 2020-04-26 at 20:31 +0800, Zou Wei wrote: > This issue was detected by using the Coccinelle software: > > tools/perf/builtin-script.c:3285:48-53: WARNING: conversion to bool not needed here > tools/perf/builtin-script.c:2839:36-41: WARNING: conversion to bool not needed here > > The conversion to bool is unneeded, remove it [] > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c [] > @@ -2836,7 +2836,7 @@ static int parse_output_fields(const struct option *opt __maybe_unused, > break; > } > if (i == imax && strcmp(tok, "flags") == 0) { > - print_flags = change == REMOVE ? false : true; > + print_flags = change == REMOVE;
Read the deleted code above this again.
(you have inverted the logic)
> continue; > } > if (i == imax) { > @@ -3282,7 +3282,7 @@ static char *get_script_path(const char *script_root, const char *suffix) > > static bool is_top_script(const char *script_path) > { > - return ends_with(script_path, "top") == NULL ? false : true; > + return ends_with(script_path, "top") == NULL;
and here.
| |