Messages in this thread | | | Date | Sun, 26 Apr 2020 19:07:19 +0200 | From | Greg KH <> | Subject | Re: [PATCH] Staging: mt7621-dma: mtk-hsdma.c: Fix Missing a blank line after declarations |
| |
On Sun, Apr 26, 2020 at 05:13:19PM +0100, John Oldman wrote: > Fixed coding style issue
No you didn't :)
> > Signed-off-by: John Oldman <john.oldman@polehill.co.uk> > --- > drivers/staging/mt7621-dma/mtk-hsdma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c > index 14592ed9ce98..dd35d0bce6ca 100644 > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c > @@ -157,6 +157,7 @@ struct mtk_hsdam_engine { > struct device_dma_parameters dma_parms; > void __iomem *base; > struct tasklet_struct task; > + > volatile unsigned long chan_issued; > > struct mtk_hsdma_chan chan[1];
This file seems to be the "does the submitter look at the patch they are sending" litmus test.
Does that really do what you think it does?
thanks,
greg k-h
| |