Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v9 00/17] Enable FSGSBASE instructions | Date | Sun, 26 Apr 2020 12:04:16 +0200 |
| |
Sasha Levin <sashal@kernel.org> writes: > On Sun, Apr 26, 2020 at 12:39:27AM +0200, Thomas Gleixner wrote: >> - Addressed the outstanding review comments > > I saw a review that Andy has just sent on patch #1 from the new series, > I'll address that.
Please look at the last version from Intel as well whether there is anything outstanding.
>> - Have proper documentation in the changelog of the user space visible >> ABI changes why it does not break any existing usage and having the >> relevant people who maintain tools which utilize the affected >> interfaces Cc'ed on submission. > > The cover letter has references to mail correspondence with maintainers > of these tools that are affected by this change. Each of those exchanges > goes over what FSGSBASE does and answers any specific questions those > maintainers had. > > If you want it out of the cover letter and into one of the patches I'd > be happy to do that. If you want me to go chase down another userspace > which we might be breaking just let me know which.
Yes, please add the information to the changelogs. That's where it really belongs.
> I didn't want to have them on the Cc line as they have already acked > this change from their end and I wanted to avoid additional noise. I'll > be happy to add them back to the next spin of this. > >> - Made sure that the cleanups I did when merging them initially have >> been picked up. I'm not going to waste another couple of days on >> this mess just to revert it because it hadn't seen any serious >> testing in development. > > Based on your revert > (https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/cpu&id=049331f277fef1c3f2527c2c9afa1d285e9a1247) > I believe that we have all the relevant patches in the series.
Ok.
Thanks,
tglx
| |