Messages in this thread | | | From | Doug Anderson <> | Date | Fri, 24 Apr 2020 10:13:43 -0700 | Subject | Re: [PATCH 2/3] soc: qcom: rpmh-rsc: Loop over less bits in irq handler |
| |
Hi,
On Fri, Apr 24, 2020 at 10:11 AM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Thu, Apr 23, 2020 at 9:54 PM Stephen Boyd <swboyd@chromium.org> wrote: > > > > readl returns a u32, and BITS_PER_LONG is different on 32-bit vs. 64-bit > > architectures. Let's make the type we stash the readl into a u32 and > > then loop over the bits set in that type instead of potentially looping > > over more bits than we will ever need to. > > > > Cc: Maulik Shah <mkshah@codeaurora.org> > > Cc: Douglas Anderson <dianders@chromium.org> > > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > > --- > > drivers/soc/qcom/rpmh-rsc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Douglas Anderson <dianders@chromium.org>
Oh, I suppose one nit is s/less/fewer/ in the subject. "bits" are discrete / countable, not continuous / uncountable.
-Doug
| |