Messages in this thread | | | Date | Thu, 23 Apr 2020 21:29:30 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] sched/pelt: sync util/runnable_sum with PELT window when propagating |
| |
On Wed, Apr 22, 2020 at 05:14:01PM +0200, Vincent Guittot wrote: > update_tg_cfs_util/runnable() propagate the impact of the attach/detach of > an entity down into the cfs_rq hierarchy which must keep the sync with > the current pelt window. > > Even if we can't sync child rq and its group se, we can sync the group se > and parent cfs_rq with current PELT window. In fact, we must keep them sync > in order to stay also synced with others se and group se that are already > attached to the cfs_rq. > > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org> > --- > kernel/sched/fair.c | 26 ++++++-------------------- > 1 file changed, 6 insertions(+), 20 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 02f323b85b6d..ca6aa89c88f2 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -3441,52 +3441,38 @@ static inline void > update_tg_cfs_util(struct cfs_rq *cfs_rq, struct sched_entity *se, struct cfs_rq *gcfs_rq) > { > long delta = gcfs_rq->avg.util_avg - se->avg.util_avg; > + u32 divider = LOAD_AVG_MAX - 1024 + cfs_rq->avg.period_contrib; > > /* Nothing to update */ > if (!delta) > return; > > - /* > - * The relation between sum and avg is: > - * > - * LOAD_AVG_MAX - 1024 + sa->period_contrib > - * > - * however, the PELT windows are not aligned between grq and gse. > - */
Instead of deleting this, could we perhaps extend it?
| |