lkml.org 
[lkml]   [2020]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] soundwire: intel: Make sdw_intel_init static
On Mon, Apr 20, 2020 at 12:42:12PM +0530, Vinod Koul wrote:
> On 10-04-20, 19:57, YueHaibing wrote:
> > Fix sparse warning:
> >
> > drivers/soundwire/intel_init.c:193:6: warning:
> > symbol 'sdw_intel_init' was not declared. Should it be static?
>
> Applied, thanks
>
> --
> ~Vinod

Why was this applied? It replaces one warning with another (that is
actually visible during a normal kernel build):

$ make -j$(nproc) -s allyesconfig drivers/soundwire/intel_init.o
drivers/soundwire/intel_init.c:193:14: warning: ‘sdw_intel_init’ defined
but not used [-Wunused-function]
static void *sdw_intel_init(acpi_handle *parent_handle,
^~~~~~~~~~~~~~

Cheers,
Nathan

\
 
 \ /
  Last update: 2020-04-23 20:03    [W:0.059 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site