lkml.org 
[lkml]   [2020]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH v9 6/9] media: tegra: Add Tegra210 Video input driver
From
Date

On 4/23/20 12:48 AM, Hans Verkuil wrote:
> External email: Use caution opening links or attachments
>
>
> On 22/04/2020 08:18, Sowjanya Komatineni wrote:
>> Tegra210 contains a powerful Video Input (VI) hardware controller
>> which can support up to 6 MIPI CSI camera sensors.
>>
>> Each Tegra CSI port can be one-to-one mapped to VI channel and can
>> capture from an external camera sensor connected to CSI or from
>> built-in test pattern generator.
>>
>> Tegra210 supports built-in test pattern generator from CSI to VI.
>>
>> This patch adds a v4l2 capture driver with media interface for
>> Tegra210 built-in CSI to VI test pattern generator.
>>
>> This patch includes TPG support only and all the video pipeline
>> configuration happens through the video device node.
>>
>> Acked-by: Thierry Reding <treding@nvidia.com>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>> drivers/staging/media/Kconfig | 2 +
>> drivers/staging/media/Makefile | 1 +
>> drivers/staging/media/tegra/Kconfig | 13 +
>> drivers/staging/media/tegra/Makefile | 8 +
>> drivers/staging/media/tegra/TODO | 10 +
>> drivers/staging/media/tegra/common.h | 262 ++++++++
>> drivers/staging/media/tegra/csi.c | 606 +++++++++++++++++
>> drivers/staging/media/tegra/csi.h | 149 +++++
>> drivers/staging/media/tegra/tegra210.c | 709 ++++++++++++++++++++
>> drivers/staging/media/tegra/tegra210.h | 190 ++++++
>> drivers/staging/media/tegra/vi.c | 1132 ++++++++++++++++++++++++++++++++
>> drivers/staging/media/tegra/vi.h | 83 +++
>> drivers/staging/media/tegra/video.c | 153 +++++
>> drivers/staging/media/tegra/video.h | 34 +
>> 14 files changed, 3352 insertions(+)
>> create mode 100644 drivers/staging/media/tegra/Kconfig
>> create mode 100644 drivers/staging/media/tegra/Makefile
>> create mode 100644 drivers/staging/media/tegra/TODO
>> create mode 100644 drivers/staging/media/tegra/common.h
>> create mode 100644 drivers/staging/media/tegra/csi.c
>> create mode 100644 drivers/staging/media/tegra/csi.h
>> create mode 100644 drivers/staging/media/tegra/tegra210.c
>> create mode 100644 drivers/staging/media/tegra/tegra210.h
>> create mode 100644 drivers/staging/media/tegra/vi.c
>> create mode 100644 drivers/staging/media/tegra/vi.h
>> create mode 100644 drivers/staging/media/tegra/video.c
>> create mode 100644 drivers/staging/media/tegra/video.h
> With 'make menuconfig' I get this:
>
> scripts/kconfig/mconf Kconfig
>
> WARNING: unmet direct dependencies detected for TEGRA_HOST1X
> Depends on [n]: HAS_IOMEM [=y] && (ARCH_TEGRA || ARM && COMPILE_TEST [=y])
> Selected by [y]:
> - VIDEO_TEGRA [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && (ARCH_TEGRA || COMPILE_TEST [=y])
>
> This is an x86_64 build with COMPILE_TEST set. I can provide my full .config if you need it.
>
> CONFIG_TEGRA_HOST1X=y
> CONFIG_VIDEO_TEGRA=y
>
> Regards,
>
> Hans

Hi Hans,

In v7, changed Kconfig to remove ARM. But looks like we should limit

TEGRA_HOST1X also limits compile to ARM only so running VIDEO_TEGRA on
x86_64 shows above warning.

We should limit compile to ARM for CONFIG_VIDEO_TEGRA.

Will update CONFIG_VIDEO_TEGRA dependency to use ARM && COMPILE_TEST
like I had in previous version. Sorry about this.


Also, I see some changes went into latest linux-next staging media
Kconfig, So, will have my patches on top of today's linux-next.

Thanks

Sowjanya


\
 
 \ /
  Last update: 2020-04-23 18:51    [W:0.122 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site