lkml.org 
[lkml]   [2020]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] perf stat: Add --metrics-file option
On Tue, Apr 21, 2020 at 01:06:30PM -0700, Andi Kleen wrote:
> > > Also there are some asserts that can be triggered by expressions. I think
> > > you should fix those too and convert them to errors.
> >
> > do you have some details on this? examples of those failures?
>
> At a minimum
>
> /* Caller must make sure id is allocated */
> void expr__add_id(struct parse_ctx *ctx, const char *name, double val)
> {
> int idx;
> assert(ctx->num_ids < MAX_PARSE_ID);
>
>
> -Andi
>

I did it and then I realized this is already caught in the parsing
code (expr.y) with this check:

if (ctx->num_ids + 1 >= EXPR_MAX_OTHER) {
pr_err("failed: way too many variables\n");
YYABORT;
}

so that assert can stay there and shouldn't be ever hit

jirka

\
 
 \ /
  Last update: 2020-04-23 15:25    [W:0.032 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site