Messages in this thread | | | Date | Thu, 23 Apr 2020 13:28:25 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v2 00/11] perf metric fixes and test |
| |
On Wed, Apr 22, 2020 at 03:04:19PM -0700, Ian Rogers wrote: > Add a test that all perf metrics (for your architecture) are > parsable. Fix bugs in the expr parser and in x86 metrics. Untested on > architectures other than x86. > > v2 adds Fixes tags to commit messages for when broken metrics were > first added. Adds a debug warning for division by zero in expr, and > adds a workaround for id values in the expr test necessary for > powerpc. It also fixes broken power8 and power9 metrics.
looks good to me
Jin Yao, is there a metric that's not working for you with this patchset applied?
thanks, jirka
> > Ian Rogers (11): > perf expr: unlimited escaped characters in a symbol > perf metrics: fix parse errors in cascade lake metrics > perf metrics: fix parse errors in skylake metrics > perf expr: allow ',' to be an other token > perf expr: increase max other > perf expr: parse numbers as doubles > perf expr: debug lex if debugging yacc > perf metrics: fix parse errors in power8 metrics > perf metrics: fix parse errors in power9 metrics > perf expr: print a debug message for division by zero > perf test: add expr test for pmu metrics > > .../arch/powerpc/power8/metrics.json | 4 +- > .../arch/powerpc/power9/metrics.json | 2 +- > .../arch/x86/cascadelakex/clx-metrics.json | 10 +- > .../arch/x86/skylakex/skx-metrics.json | 4 +- > tools/perf/tests/builtin-test.c | 5 + > tools/perf/tests/expr.c | 96 ++++++++++++++++++- > tools/perf/tests/tests.h | 2 + > tools/perf/util/expr.c | 1 + > tools/perf/util/expr.h | 2 +- > tools/perf/util/expr.l | 16 ++-- > tools/perf/util/expr.y | 16 +++- > 11 files changed, 135 insertions(+), 23 deletions(-) > > -- > 2.26.2.303.gf8c07b1a785-goog >
| |