lkml.org 
[lkml]   [2020]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] brd: remove a redundant check
From
Date


On 2020/4/22 9:28, Zhen Lei wrote:
> Because pages[i] can't be NULL, otherwise "pos = pages[i]->index;" will
> panic. So when "ret" is NULL, it can't be equal to pages[i].

In fact, "ret != pages[i]" is clear enough.

>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/block/brd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index 2fb25c348d53..59fec4a8ac93 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -147,7 +147,7 @@ static void brd_free_pages(struct brd_device *brd)
> BUG_ON(pages[i]->index < pos);
> pos = pages[i]->index;
> ret = radix_tree_delete(&brd->brd_pages, pos);
> - BUG_ON(!ret || ret != pages[i]);
> + BUG_ON(ret != pages[i]);
> __free_page(pages[i]);
> }
>
>

\
 
 \ /
  Last update: 2020-04-24 04:09    [W:0.408 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site