Messages in this thread | | | From | Aisheng Dong <> | Subject | RE: [PATCH V2] dt-bindings: firmware: imx: Move system control into dt-binding headfile | Date | Fri, 24 Apr 2020 01:48:31 +0000 |
| |
> From: Anson Huang <anson.huang@nxp.com> > Sent: Friday, April 24, 2020 6:29 AM > > > Subject: RE: [PATCH V2] dt-bindings: firmware: imx: Move system > > control into dt-binding headfile > > > > > From: Anson Huang <Anson.Huang@nxp.com> > > > Sent: Thursday, April 23, 2020 11:36 PM > > > > > > i.MX8 SoCs DTS file needs system control macro definitions, so move > > > them into dt-binding headfile, then > > > include/linux/firmware/imx/types.h > > > can be removed and those drivers using it should be changed accordingly. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > You seems ignored my comments in V1. > > Usually we'd better to keep original author when sending patches if no > > fundamental changes. > > Here is the details, the aim of this patch is to get rid of below patch in internal > tree, I did NOT check the details of internal tree and did the patch manually and > did NOT check how many patches I need in internal tree in order to make the > build passed. After checking it, looks like there are 3 patches, 2 are from you, > and 1 from Jacky. Since these patches need to be squashed into 1 patch, also fix > minor comment in code and improve the comment, so, should I put you as > author or Jacky as author?? >
As there're no code changes, for such a case, we usually keep origin author and add Jacky signoff and you signoff.
Regards Aisheng
> commit cb6603999367aeae57004638a4b8e43ee618dbec > Author: Jacky Bai <ping.bai@nxp.com> > Date: Mon Mar 9 14:41:44 2020 +0800 > > thermal: imx_sc_thermal: fix the build break caused non existent types.h > > The types.h has been move to the dt-bindings/, so correct the included > header file to fix the build break.
| |