lkml.org 
[lkml]   [2020]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 03/64] scsi: sg: add sg_remove_request in sg_common_write
    Date
    From: Li Bin <huawei.libin@huawei.com>

    commit 849f8583e955dbe3a1806e03ecacd5e71cce0a08 upstream.

    If the dxfer_len is greater than 256M then the request is invalid and we
    need to call sg_remove_request in sg_common_write.

    Link: https://lore.kernel.org/r/1586777361-17339-1-git-send-email-huawei.libin@huawei.com
    Fixes: f930c7043663 ("scsi: sg: only check for dxfer_len greater than 256M")
    Acked-by: Douglas Gilbert <dgilbert@interlog.com>
    Signed-off-by: Li Bin <huawei.libin@huawei.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/sg.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/scsi/sg.c
    +++ b/drivers/scsi/sg.c
    @@ -808,8 +808,10 @@ sg_common_write(Sg_fd * sfp, Sg_request
    "sg_common_write: scsi opcode=0x%02x, cmd_size=%d\n",
    (int) cmnd[0], (int) hp->cmd_len));

    - if (hp->dxfer_len >= SZ_256M)
    + if (hp->dxfer_len >= SZ_256M) {
    + sg_remove_request(sfp, srp);
    return -EINVAL;
    + }

    k = sg_start_req(srp, cmnd);
    if (k) {

    \
     
     \ /
      Last update: 2020-04-22 12:14    [W:4.063 / U:0.496 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site