Messages in this thread | | | Subject | Re: [PATCH v2] stacktrace: cleanup inconsistent variable type | From | Bart Van Assche <> | Date | Wed, 22 Apr 2020 18:21:13 -0700 |
| |
On 4/20/20 6:35 PM, Walter Wu wrote: > Modify the variable type of 'skip' member of struct stack_trace. > In theory, the 'skip' variable type should be unsigned int. > There are two reasons: > - The 'skip' only has two situation, 1)Positive value, 2)Zero > - The 'skip' of struct stack_trace has inconsistent type with struct > stack_trace_data, it makes a bit confusion in the relationship between > struct stack_trace and stack_trace_data.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
| |