Messages in this thread | | | Date | Wed, 22 Apr 2020 15:16:43 -0700 | From | Nathan Chancellor <> | Subject | Re: [PATCH v5] MIPS: Truncate link address into 32bit for 32bit kernel |
| |
On Wed, Apr 22, 2020 at 10:32:54PM +0800, Jiaxun Yang wrote: > LLD failed to link vmlinux with 64bit load address for 32bit ELF > while bfd will strip 64bit address into 32bit silently. > To fix LLD build, we should truncate load address provided by platform > into 32bit for 32bit kernel. > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> > Link: https://github.com/ClangBuiltLinux/linux/issues/786 > Link: https://sourceware.org/bugzilla/show_bug.cgi?id=25784 > Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org> > Reviewed-by: Fangrui Song <maskray@google.com> > Reviewed-by: Kees Cook <keescook@chromium.org> > Cc: Nathan Chancellor <natechancellor@gmail.com> > -- > V2: Take MaskRay's shell magic. > > V3: After spent an hour on dealing with special character issue in > Makefile, I gave up to do shell hacks and write a util in C instead. > Thanks Maciej for pointing out Makefile variable problem. > > v4: Finally we managed to find a Makefile method to do it properly > thanks to Kees. As it's too far from the initial version, I removed > Review & Test tag from Nick and Fangrui and Cc instead. > > v5: Care vmlinuz as well.
Tested-by: Nathan Chancellor <natechancellor@gmail.com>
| |